[PATCH] D78549: Improve disassembly of branch targets in non-relocatable objects

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 21 04:49:53 PDT 2020


jhenderson updated this revision to Diff 258964.
jhenderson marked 7 inline comments as done.
jhenderson added a comment.

Addressed review comments:

- clang-formatted
- improved comments and variable names
- slight tweak to lambda
- used SHN_ABS and provided it via yaml2obj to allow removal of llvm-objcopy run in test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78549/new/

https://reviews.llvm.org/D78549

Files:
  llvm/test/tools/llvm-objdump/X86/disassemble-same-section-addr.test
  llvm/tools/llvm-objdump/llvm-objdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78549.258964.patch
Type: text/x-patch
Size: 9394 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200421/3d0edffc/attachment.bin>


More information about the llvm-commits mailing list