[PATCH] D78243: New pass to make internal linkage symbol names unique

[Eric Christopher via llvm-commits]

On Mon, Apr 20, 2020 at 3:46 PM Sriraman Tallam via Phabricator <
reviews at reviews.llvm.org> wrote:

> tmsriram added a comment.
>
> In D78243#1993284 <https://reviews.llvm.org/D78243#1993284>, @echristo
> wrote:
>
> > In D78243#1990101 <https://reviews.llvm.org/D78243#1990101>, @tmsriram
> wrote:
> >
> > > In D78243#1990057 <https://reviews.llvm.org/D78243#1990057>, @MaskRay
> wrote:
> > >
> > > > You may need an `opt -passes='...'` test for the new pass manager
> and implement the new pass.
> > > >
> > > > We are using `-fexperimental-new-pass-manager` heavily.
> > >
> > >
> > > I am already testing -fexperimental-new-pass-manager in D73307 <
> https://reviews.llvm.org/D73307>, need to do it here?
> >
> >
> > Probably wouldn't hurt to have both an explicit test for each pass
> manager.
>
>
> I saw this after I pushed.  I can follow it up with a test.
>

No worries, I didn't reply until after you'd pushed :)

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200420/c4dfad8e/attachment.html>