<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Apr 20, 2020 at 3:46 PM Sriraman Tallam via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">tmsriram added a comment.<br>
<br>
In D78243#1993284 <<a href="https://reviews.llvm.org/D78243#1993284" rel="noreferrer" target="_blank">https://reviews.llvm.org/D78243#1993284</a>>, @echristo wrote:<br>
<br>
> In D78243#1990101 <<a href="https://reviews.llvm.org/D78243#1990101" rel="noreferrer" target="_blank">https://reviews.llvm.org/D78243#1990101</a>>, @tmsriram wrote:<br>
><br>
> > In D78243#1990057 <<a href="https://reviews.llvm.org/D78243#1990057" rel="noreferrer" target="_blank">https://reviews.llvm.org/D78243#1990057</a>>, @MaskRay wrote:<br>
> ><br>
> > > You may need an `opt -passes='...'` test for the new pass manager and implement the new pass.<br>
> > ><br>
> > > We are using `-fexperimental-new-pass-manager` heavily.<br>
> ><br>
> ><br>
> > I am already testing -fexperimental-new-pass-manager in D73307 <<a href="https://reviews.llvm.org/D73307" rel="noreferrer" target="_blank">https://reviews.llvm.org/D73307</a>>, need to do it here?<br>
><br>
><br>
> Probably wouldn't hurt to have both an explicit test for each pass manager.<br>
<br>
<br>
I saw this after I pushed.  I can follow it up with a test.<br></blockquote><div><br></div><div>No worries, I didn't reply until after you'd pushed :)</div><div><br></div><div>-eric </div></div></div>