[PATCH] D77564: [PowerPC] Do not attempt to reuse load for 64-bit FP_TO_UINT without FPCVT

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 20 08:37:55 PDT 2020


nemanjai marked an inline comment as done.
nemanjai added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/pr43976.ll:4
+; RUN:   -ppc-asm-full-reg-names < %s | FileCheck %s
+ at a = dso_local local_unnamed_addr global double 0.000000e+00, align 8
+
----------------
sfertile wrote:
> We can reduce the test further and still exercise the assertion:
> 
> 
> ```
> define dso_local double @b(double) local_unnamed_addr {
> entry:
>   %conv = fptoui double %0 to i64
>   %conv1 = sitofp i64 %conv to double
>   ret double %conv1
> }
> ```
I initially reduced this down to something like that, but chose not to go ahead with that for two reasons:
1. The test case in the PR is simple enough and I wanted the test case to actually represent the reported test
2. I am not sure if some DAG combine in the future might fold the operations into something different


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77564/new/

https://reviews.llvm.org/D77564





More information about the llvm-commits mailing list