[PATCH] D78468: [VE] Update shift operation instructions
Simon Moll via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 20 00:30:10 PDT 2020
simoll added a comment.
LGTM for the most part. One comment inline.
================
Comment at: llvm/lib/Target/VE/VEInstrInfo.td:1083
// TODO Use standard expansion for shift-based lowering of sext_inreg
----------------
Couldn't we just use LLVM's expansion legalizer for sext_inreg instead of specifying a pattern here? If not, then this comment should be removed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78468/new/
https://reviews.llvm.org/D78468
More information about the llvm-commits
mailing list