[PATCH] D78340: [Flang] fix dependency issues after D78215

Stephen Neuendorffer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 19 17:37:03 PDT 2020


stephenneuendorffer added a comment.

FWIW, I think my expectations are correct, if you include the dialect libraries as a PUBLIC dependency.  In your case, using LINK_LIBS results in target_link_libraries being called with all the libraries as INTERFACE libraries.
It's unclear why there is a distinction made here, since it seems logical that cmake handles PUBLIC and INTERFACE dependencies the same with respect to header files, but there must be some reason :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78340/new/

https://reviews.llvm.org/D78340





More information about the llvm-commits mailing list