[PATCH] D78340: [Flang] fix dependency issues after D78215
Valentin Clement via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 17 10:14:45 PDT 2020
clementval added a comment.
In D78340#1989032 <https://reviews.llvm.org/D78340#1989032>, @DavidTruby wrote:
> I can reproduce @clementval's issue, but only when using `make` and not when using `ninja` which seems very odd to me. I do also expect the circular dependency to be needed at the moment so I think this patch is correct on that point. Fixing the circular dependency needs work outside the build system as there is actually a circular dependency in the code.
> I'm inclined to say that given we broke something that used to work, we should merge this patch to fix that even if it breaks things that the last patch fixed.
I'm using make since I do not have ninja on the system I used currently and cannot install it. This is probably why I see the problem.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78340/new/
https://reviews.llvm.org/D78340
More information about the llvm-commits
mailing list