[PATCH] D78446: [MLIR] NFC Fix/clarify line in const usage rationale doc

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 18 23:58:08 PDT 2020


This revision was automatically updated to reflect the committed changes.
Closed by commit rG9412e4c9c67a: [MLIR] NFC Fix/clarify line in const usage rationale doc (authored by bondhugula).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78446/new/

https://reviews.llvm.org/D78446

Files:
  mlir/docs/Rationale/UsageOfConst.md


Index: mlir/docs/Rationale/UsageOfConst.md
===================================================================
--- mlir/docs/Rationale/UsageOfConst.md
+++ mlir/docs/Rationale/UsageOfConst.md
@@ -257,8 +257,8 @@
 significant cost, and given that the primary purpose of an IR is to represent
 transformations of code, const is providing very little benefit.
 
-As such, we propose eliminating support for const references in MLIR. This
-implies the following changes to the codebase:
+As such, we propose eliminating support for const references to IR objects in
+MLIR.  This implies the following changes to the codebase:
 
 1.  All of the const-duplicated accessors would be eliminated, e.g.
     `Operation::getParent() const` would be removed. This is expected to remove


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78446.258585.patch
Type: text/x-patch
Size: 773 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200419/74afc5a7/attachment.bin>


More information about the llvm-commits mailing list