[PATCH] D78446: [MLIR] NFC Fix/clarify line in const usage rationale doc

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula created this revision.
bondhugula added reviewers: rriddle, mehdi_amini.
Herald added subscribers: llvm-commits, frgossen, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar.
Herald added a project: LLVM.
rriddle accepted this revision.
This revision is now accepted and ready to land.

Update misleading line in conclusions. Although the application to IR
objects is stated earlier, the concluding section contradicts it in
isolation.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78446

Files:
  mlir/docs/Rationale/UsageOfConst.md


Index: mlir/docs/Rationale/UsageOfConst.md
===================================================================
--- mlir/docs/Rationale/UsageOfConst.md
+++ mlir/docs/Rationale/UsageOfConst.md
@@ -257,8 +257,8 @@
 significant cost, and given that the primary purpose of an IR is to represent
 transformations of code, const is providing very little benefit.
 
-As such, we propose eliminating support for const references in MLIR. This
-implies the following changes to the codebase:
+As such, we propose eliminating support for const references to IR objects in
+MLIR.  This implies the following changes to the codebase:
 
 1.  All of the const-duplicated accessors would be eliminated, e.g.
     `Operation::getParent() const` would be removed. This is expected to remove


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78446.258579.patch
Type: text/x-patch
Size: 773 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200419/7ade3e5b/attachment.bin>