[PATCH] D78426: [MLIR] Move `replaceAllUsesExcept` from LoopUtil.h to Value.h.

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 18 22:37:27 PDT 2020


bondhugula added inline comments.


================
Comment at: mlir/include/mlir/IR/Value.h:19
 #include "mlir/Support/LLVM.h"
+#include "llvm/ADT/SmallPtrSet.h"
 #include "llvm/Support/PointerLikeTypeTraits.h"
----------------
rriddle wrote:
> Please don't add includes here, if it is truly necessary move it to the .cpp file.
This include is actually not necessary. SmallPtrSet and its impl is already fwd decl'ed in mlir/Support/LLVM.h. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78426/new/

https://reviews.llvm.org/D78426





More information about the llvm-commits mailing list