[PATCH] D78426: [MLIR] Move `replaceAllUsesExcept` from LoopUtil.h to Value.h.

[River Riddle via Phabricator via llvm-commits]

rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/include/mlir/IR/Value.h:19
 #include "mlir/Support/LLVM.h"
+#include "llvm/ADT/SmallPtrSet.h"
 #include "llvm/Support/PointerLikeTypeTraits.h"
----------------
Please don't add includes here, if it is truly necessary move it to the .cpp file.


================
Comment at: mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp:112
       Value oldIndex = block.getArgument(i);
       Value newIndex = b.create<AddIOp>(indexedGenericOp.getLoc(), oldIndex,
                                         loopRanges[i].offset);
----------------
nit: Change the type of newIndex to AddIOp to avoid needing to recover the defining op.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78426/new/

https://reviews.llvm.org/D78426