[PATCH] D78310: [ProfileSummary] Add partial profile annotation on IR.

[Wei Mi via Phabricator via llvm-commits]

wmi marked 2 inline comments as done.
wmi added a comment.

There are also a lot of tests which need to be updated because of the extra ProfileSummary MetaData component.



================
Comment at: llvm/lib/IR/ProfileSummary.cpp:180
     return nullptr;
+  if (!getVal(dyn_cast<MDTuple>(Tuple->getOperand(6)), "IsPartialProfile",
+              IsPartialProfile))
----------------
yamauchi wrote:
> yamauchi wrote:
> > Does this need to be the 7th operand instead of 6?
> (A small roundtrip test, eg. unittest/ProfileData/SampleProfTest.cpp, may be helpful to exercise getMD/getFromMD.)
Fixed.


================
Comment at: llvm/lib/IR/ProfileSummary.cpp:180
     return nullptr;
+  if (!getVal(dyn_cast<MDTuple>(Tuple->getOperand(6)), "IsPartialProfile",
+              IsPartialProfile))
----------------
wmi wrote:
> yamauchi wrote:
> > yamauchi wrote:
> > > Does this need to be the 7th operand instead of 6?
> > (A small roundtrip test, eg. unittest/ProfileData/SampleProfTest.cpp, may be helpful to exercise getMD/getFromMD.)
> Fixed.
Good point. Done.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78310/new/

https://reviews.llvm.org/D78310