[PATCH] D78310: [ProfileSummary] Add partial profile annotation on IR.
Hiroshi Yamauchi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 17 09:10:03 PDT 2020
yamauchi added inline comments.
================
Comment at: llvm/lib/IR/ProfileSummary.cpp:180
return nullptr;
+ if (!getVal(dyn_cast<MDTuple>(Tuple->getOperand(6)), "IsPartialProfile",
+ IsPartialProfile))
----------------
yamauchi wrote:
> Does this need to be the 7th operand instead of 6?
(A small roundtrip test, eg. unittest/ProfileData/SampleProfTest.cpp, may be helpful to exercise getMD/getFromMD.)
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78310/new/
https://reviews.llvm.org/D78310
More information about the llvm-commits
mailing list