[PATCH] D78202: [FileCheck] - Refactor the code related to string arrays. NFCI.

[George Rimar via Phabricator via llvm-commits]

grimar updated this revision to Diff 258496.
grimar added a comment.

Thinking about it again I do not think that is *too* subtle to hold `StringRef` for options like
`static cl::list<std::string> ImplicitCheckNot`. They are static variables and expected to live the whole
time while application is running. It also would be strange for them to change after initialization,
hence:

- Reverted to the previous version (without `BumpPtrAllocator`).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78202/new/

https://reviews.llvm.org/D78202

Files:
  llvm/include/llvm/Support/FileCheck.h
  llvm/lib/Support/FileCheck.cpp
  llvm/lib/Support/FileCheckImpl.h
  llvm/unittests/Support/FileCheckTest.cpp
  llvm/utils/FileCheck/FileCheck.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78202.258496.patch
Type: text/x-patch
Size: 10906 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200418/64cd0988/attachment.bin>