[PATCH] D78234: [BranchFolding] assert when removing INLINEASM_BR indirect targets

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 17 14:37:19 PDT 2020


efriedma added a comment.

> That sounds like you really really want MachineBasicBlocks as MachineOperands for INLINEASM_BR, as opposed to BlockAddresses?

Yes. :)

> Though MachineBasicBlock MachineOperands still doesn't necessarily integrate with successor tracking.

It doesn't really need to.  Any code that doesn't understand INLINEASM_BR will do the right thing anyway.  There are other branch instructions that target-independent code can't analyze.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78234/new/

https://reviews.llvm.org/D78234





More information about the llvm-commits mailing list