[PATCH] D78234: [BranchFolding] assert when removing INLINEASM_BR indirect targets

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added a comment.

In D78234#1989382 <https://reviews.llvm.org/D78234#1989382>, @efriedma wrote:

> If we're going to store more information on the MachineInstr, I'd prefer to store it in the form of Operands, not some custom data structure.


That sounds like you really really want `MachineBasicBlock`s as `MachineOperand`s for `INLINEASM_BR`, as opposed to `BlockAddress`es?

> The reason I'm concerned here is that the InlineAsmBrIndirectTargets map doesn't cooperate with the other mechanism for tracking successors, so operations like splitting a basic block won't update it.

Though `MachineBasicBlock` `MachineOperand`s still doesn't necessarily integrate with successor tracking.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78234/new/

https://reviews.llvm.org/D78234