[PATCH] D78340: [Flang] fix dependency issues after D78215

[Valentin Clement via Phabricator via llvm-commits]

clementval marked 2 inline comments as done.
clementval added a comment.

In D78340#1988692 <https://reviews.llvm.org/D78340#1988692>, @ChinouneMehdi wrote:

> I think this change will fix your problem: D78354 <https://reviews.llvm.org/D78354>
>  Just a question: Have you try to investigate where the problem is before making these changes?


Of course I did. Do you think I just randomly try something to fix it. I find your comment quite offensive, please try to think before asking this kind of question. Your patch for sure doesn't fix my problem with FIRSemantics.



================
Comment at: flang/lib/Evaluate/CMakeLists.txt:32
   FortranDecimal
+  FortranSemantics
   FortranParser
----------------
ChinouneMehdi wrote:
> clementval wrote:
> > ChinouneMehdi wrote:
> > > You are reintroducing a cycle-dependency between FortranEvaluate and FortranSemantics, and in addition FortranEvaluate doesn't call any function from FortranSemantics.
> > On my system there is a linking problem without this. 
> Could you remove this unrelated dependency.
I just mentioned that it is needed. If on your system it works this is not the case for everybody. You tied your patch with 3 compilers and on one system. The reality is much more complex. 


================
Comment at: flang/lib/Optimizer/Dialect/CMakeLists.txt:9
   FIROpsIncGen
+  FIRSupport
 
----------------
ChinouneMehdi wrote:
> clementval wrote:
> > ChinouneMehdi wrote:
> > > FortranSupport is already declared as a dependency, why!
> > Compile time dependency and link time dependency are not the same. 
> Your problem was occurring with FIRSupport, so why introducing this dependency to FIRDialect?
Obviously, I didn't attached the 5-6 errors occurring. The change I posted in this patch are needed at least on the system I used to compile Flang (Summit node). 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78340/new/

https://reviews.llvm.org/D78340