[PATCH] D78340: [Flang] fix dependenvy issues after D78215

[مهدي شينون (Mehdi Chinoune) via Phabricator via llvm-commits]

ChinouneMehdi added inline comments.


================
Comment at: flang/lib/Evaluate/CMakeLists.txt:32
   FortranDecimal
+  FortranSemantics
   FortranParser
----------------
clementval wrote:
> ChinouneMehdi wrote:
> > You are reintroducing a cycle-dependency between FortranEvaluate and FortranSemantics, and in addition FortranEvaluate doesn't call any function from FortranSemantics.
> On my system there is a linking problem without this. 
Could you remove this unrelated dependency.


================
Comment at: flang/lib/Optimizer/Dialect/CMakeLists.txt:9
   FIROpsIncGen
+  FIRSupport
 
----------------
clementval wrote:
> ChinouneMehdi wrote:
> > FortranSupport is already declared as a dependency, why!
> Compile time dependency and link time dependency are not the same. 
Your problem was occurring with FIRSupport, so why introducing this dependency to FIRDialect?


================
Comment at: flang/lib/Optimizer/Support/CMakeLists.txt:6-7
 
+  DEPENDS
+  ${dialect_libs}
   LINK_LIBS
----------------
clementval wrote:
> ChinouneMehdi wrote:
> > Same here!
> This is needed as this is a compile time dependency as well. Before your patch everything was compiling fine. But not after it. Those change are fixing the problem your introduced on the system I use at least. 
The problem was because of a file that wasn't generated before building FIRSupport, so to fix the problem it suffices to introduce a dependency on it ( implicitly or explicitly).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78340/new/

https://reviews.llvm.org/D78340