[PATCH] D76728: [AArch64][SVE] Add DestructiveBinaryImm SQSHLU patterns.

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 16 11:41:47 PDT 2020


cameron.mcinally marked an inline comment as done.
cameron.mcinally added a comment.

In D76728#1986939 <https://reviews.llvm.org/D76728#1986939>, @c-rhodes wrote:

> @cameron.mcinally thanks for the patch! Just one minor nit, otherwise LGTM. Is it be worth setting the `DestructiveInstType` in this patch also given it'll only be a couple of line change?


It's already set to DestructiveBinaryImm in the sve_int_bin_pred_shift_imm class.



================
Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:4752
   let Constraints = "$Zdn = $_Zdn";
   let DestructiveInstType = DestructiveBinaryImm;
   let ElementSize = zprty.ElementSize;
----------------
DestructiveInstType is set here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76728/new/

https://reviews.llvm.org/D76728





More information about the llvm-commits mailing list