[PATCH] D76728: [AArch64][SVE] Add DestructiveBinaryImm SQSHLU patterns.

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 16 10:02:05 PDT 2020


c-rhodes accepted this revision.
c-rhodes added a comment.
This revision is now accepted and ready to land.

@cameron.mcinally thanks for the patch! Just one minor nit, otherwise LGTM. Is it be worth setting the `DestructiveInstType` in this patch also given it'll only be a couple of line change?



================
Comment at: llvm/test/CodeGen/AArch64/sve2-intrinsics-uniform-dsp-zeroing.ll:14
+  %out = call <vscale x 16 x i8> @llvm.aarch64.sve.sqshlu.nxv16i8(<vscale x 16 x i1> %pg,
+                                                             <vscale x 16 x i8> %a_z,
+                                                             i32 2)
----------------
nit: align args (and below)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76728/new/

https://reviews.llvm.org/D76728





More information about the llvm-commits mailing list