[PATCH] D62475: Change DIEnumerator payload type to APInt

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 15 17:07:06 PDT 2020


aprantl added inline comments.


================
Comment at: llvm/lib/Bitcode/Reader/MetadataLoader.cpp:1213
     bool IsUnsigned = Record[0] & 2;
+    bool IsBigInt = Record[0] & 4;
+    APInt Value;
----------------
aprantl wrote:
> Should we use LEB128 encoding here — does that make the parser simpler?
Alternatively, how do we encode an APInt constant in bitcode otherwise, could we factor out and reuse that code here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62475/new/

https://reviews.llvm.org/D62475





More information about the llvm-commits mailing list