[PATCH] D62475: Change DIEnumerator payload type to APInt

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/IR/LLVMContextImpl.h:360
   MDString *Name;
   bool IsUnsigned;
 
----------------
Is this needed any more, doesn't the APInt have a sign bit already?


================
Comment at: llvm/test/Assembler/DIEnumeratorBig.ll:7
+!llvm.module.flags = !{!13, !14, !15}
+!llvm.ident = !{!16}
+
----------------
This looks good, though you might be able to shorten this test by just having a bunch of standalone DIEnumerator nodes that are listed in a named MDNode. (See other round trip tests for examples)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62475/new/

https://reviews.llvm.org/D62475