[PATCH] D78196: [PowerPC] Clear the set of symbols that need to be updated in MCTargetStreamer
Nemanja Ivanovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 15 12:37:00 PDT 2020
nemanjai added a comment.
In D78196#1984391 <https://reviews.llvm.org/D78196#1984391>, @MaskRay wrote:
> Then it seems the cleanup should be placed in a derived function of `MCStreamer::reset()`?
`MCTargetStreamer` is a member of `MCStreamer` not a class derived from it. Of course, we could do something similar to what `ARMTargetStreamer` does and provide `virtual void reset()` that the derived classes can then implement and override and that `MCStreamer::reset()` would call. Since this does not appear to have been needed elsewhere before, this seems unnecessary, but I am certainly not against extending `MCTargetStreamer` this way if that is preferred.
Would you prefer that I do that?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78196/new/
https://reviews.llvm.org/D78196
More information about the llvm-commits
mailing list