[PATCH] D78196: [PowerPC] Clear the set of symbols that need to be updated in MCTargetStreamer
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 15 11:34:26 PDT 2020
MaskRay added a comment.
In D78196#1984264 <https://reviews.llvm.org/D78196#1984264>, @nemanjai wrote:
> In D78196#1983864 <https://reviews.llvm.org/D78196#1983864>, @MaskRay wrote:
>
> > Isn't it a Julia usage error? After `MCStreamer::Finish`, MCStreamer isn't supposed to be reused. In LLVM code, it is definitely not...
>
>
> Are you sure about this? Why does `MCStreamer::reset()` exist?
Then it seems the cleanup should be placed in `MCStreamer::reset()`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78196/new/
https://reviews.llvm.org/D78196
More information about the llvm-commits
mailing list