[PATCH] D78177: [VE] Update logical operation instructions

Wed Apr 15 02:41:54 PDT 2020

simoll added inline comments.

================
Comment at: llvm/lib/Target/VE/VEInstrInfo.td:913
+let cw = 1, cw2 = 1 in defm CMOVS : RRCMOVm<"cmov.s.${cfw}", 0x3B, F32, f32>;
+def : MnemonicAlias<"cmov.l", "cmov.l.at">;
+def : MnemonicAlias<"cmov.w", "cmov.w.at">;
----------------
kaz7 wrote:
> simoll wrote:
> > First time i am seeing this feature. Do we need this to match mnemonic aliases when parsing assembly?
> Yes.  With this MenmonicAlias, llvm-mc can parse "cmov.l" as a shorten "cmov.l.at" instruction.  NEC assembler allows both of them, so we also allow them to maximize user's choices.
> 
> May I defer these to coming llvm-mc patch sets?
> May I defer these to coming llvm-mc patch sets?
I guess so. It sounds like we won't need MnemonicAliases before we have MC layer support (and probably couldn't test it right now).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78177/new/

https://reviews.llvm.org/D78177