[PATCH] D77971: [MC][X86][NFC] Disable branch align in non-text section

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 15 01:36:08 PDT 2020


skan marked an inline comment as done.
skan added a comment.

In D77971#1982735 <https://reviews.llvm.org/D77971#1982735>, @MaskRay wrote:

>




> You can delete the label `foo:`, which isn't used.

label `foo` is used by jmp.



================
Comment at: llvm/test/MC/X86/align-branch-section-size.s:6
 
   # CHECK:  Name: text1
   # CHECK:  AddressAlignment: 32
----------------
MaskRay wrote:
> Such test is fragile.
> 
> ```
> # CHECK: Name: text1
> # CHECK: AddressAlignment:
> # CHECK:                   32{$}
> ```
> 
> may be slightly better.
It's strange to write like this. It may check something like
```
AddressAlignment:  1
32
```
Lots of tests use the format `CHECK:     AddressAlignment: 1`, such as test/tools/llvm-readobj/ELF/sections.test. So I prefer to not change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77971/new/

https://reviews.llvm.org/D77971





More information about the llvm-commits mailing list