[PATCH] D77971: [MC][X86][NFC] Disable branch align in non-text section

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D77971#1982624 <https://reviews.llvm.org/D77971#1982624>, @skan wrote:

> In D77971#1981345 <https://reviews.llvm.org/D77971#1981345>, @MaskRay wrote:
>
> > If we consider instructions in non-SHF_EXECINSTR sections an undefined behavior. Then erroring out is as good as not erroring out. For an "undefined behavior" I would prefer a diagnostic if a user can reasonably cause the error, but this probably requires some testing on some larger code bases. I hope no project depends on the erroneous behavior. If we don't error, I would prefer the simple choice: don't do anything specially.
>
>
> So, to make things easier, could I commit the change in align-branch-section-size.s in a NFC first? @MaskRay


`llvm/test/MC/X86/align-branch-section-size.s` looks good. I might suggest `"ax"` originally...

You can delete the label `foo:`, which isn't used.



================
Comment at: llvm/test/MC/X86/align-branch-section-size.s:6
 
   # CHECK:  Name: text1
   # CHECK:  AddressAlignment: 32
----------------
Such test is fragile.

```
# CHECK: Name: text1
# CHECK: AddressAlignment:
# CHECK:                   32{$}
```

may be slightly better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77971/new/

https://reviews.llvm.org/D77971