[PATCH] D78177: [VE] Update logical operation instructions

Simon Moll via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 15 01:03:45 PDT 2020


simoll added a reviewer: arsenm.
simoll added a comment.
Herald added a subscriber: wdng.

I am not knowledgeable enough to review the use of `MnemonicAlias` here but everything else LGTM.



================
Comment at: llvm/lib/Target/VE/VEInstrInfo.td:913
+let cw = 1, cw2 = 1 in defm CMOVS : RRCMOVm<"cmov.s.${cfw}", 0x3B, F32, f32>;
+def : MnemonicAlias<"cmov.l", "cmov.l.at">;
+def : MnemonicAlias<"cmov.w", "cmov.w.at">;
----------------
First time i am seeing this feature. Do we need this to match mnemonic aliases when parsing assembly?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78177/new/

https://reviews.llvm.org/D78177





More information about the llvm-commits mailing list