[PATCH] D77124: Handle CET for -exception-model sjlj

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/Target/X86/X86IndirectBranchTracking.cpp:152
+        // New Landingpad BB without EHLabel.
+        if (MBB.isEHPad()) {
+          if (I->isDebugInstr())
----------------
xiangzhangllvm wrote:
> LuoYuanke wrote:
> > The isEHPad() include CatchSwitch, CatchPad, CleanupPad and LandingPad. Do we want to insert endbr to all of them or just for LandingPad?
> The LandingPad is the exception where will be indirectly jump when the exception happen. The others uses direct jump, them belong to the "internal exception handle block" following the LandingPad.
Yes. Could you extend your test case to cover CatchPad or some other Pad to make sure we don't insert endbr on these blocks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77124/new/

https://reviews.llvm.org/D77124