[PATCH] D77124: Handle CET for -exception-model sjlj
Xiang Zhang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 14 23:22:51 PDT 2020
xiangzhangllvm marked an inline comment as done.
xiangzhangllvm added inline comments.
================
Comment at: llvm/lib/Target/X86/X86IndirectBranchTracking.cpp:152
+ // New Landingpad BB without EHLabel.
+ if (MBB.isEHPad()) {
+ if (I->isDebugInstr())
----------------
LuoYuanke wrote:
> The isEHPad() include CatchSwitch, CatchPad, CleanupPad and LandingPad. Do we want to insert endbr to all of them or just for LandingPad?
The LandingPad is the exception where will be indirectly jump when the exception happen. The others uses direct jump, them belong to the "internal exception handle block" following the LandingPad.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77124/new/
https://reviews.llvm.org/D77124
More information about the llvm-commits
mailing list