[PATCH] D77198: Introduce fix-irreducible pass

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds marked 2 inline comments as done.
sameerds added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/FixIrreducible.cpp:81
+namespace {
+struct FixIrreducible : public FunctionPass {
+  static char ID;
----------------
nhaehnle wrote:
> Nitpick: it's common to use 'class' for passes (not that it makes a real difference especially here...)
There are other examples with a struct, and some with a class whose entire body is public anyway. So decided to keep the struct.


================
Comment at: llvm/lib/Transforms/Utils/FixIrreducible.cpp:230-233
+  NewLoop->verifyLoop();
+  if (ParentLoop) {
+    ParentLoop->verifyLoop();
+  }
----------------
nhaehnle wrote:
> #ifndef NDEBUG for the verifyLoop calls?
The body of verifyLoop() is itself guarded with NDEBUG. There are places where it is called without guards, including LoopPass itself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77198/new/

https://reviews.llvm.org/D77198