[PATCH] D77198: Introduce fix-irreducible pass

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

Two minor nitpicks, apart from that it LGTM



================
Comment at: llvm/lib/Transforms/Utils/FixIrreducible.cpp:81
+namespace {
+struct FixIrreducible : public FunctionPass {
+  static char ID;
----------------
Nitpick: it's common to use 'class' for passes (not that it makes a real difference especially here...)


================
Comment at: llvm/lib/Transforms/Utils/FixIrreducible.cpp:230-233
+  NewLoop->verifyLoop();
+  if (ParentLoop) {
+    ParentLoop->verifyLoop();
+  }
----------------
#ifndef NDEBUG for the verifyLoop calls?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77198/new/

https://reviews.llvm.org/D77198