[PATCH] D78147: [LICM] Try to merge debug locations when sinking

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 14 16:52:38 PDT 2020


vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

Looks good to me with a minor test update. @dblaikie?



================
Comment at: llvm/test/Transforms/LICM/sink-debuginfo-preserve.ll:9
+; CHECK-NEXT: store i32 %.lcssa, i32* getelementptr inbounds ([2 x i32], [2 x i32]* @g_390, i64 0, i64 1), align 4, !dbg !58, !tbaa !40
+; CHECK: !58 = !DILocation(line: 0, scope: !29)
+
----------------
Probably less brittle to match `!dbg [[storeLocation:![0-9]+]]` and then check `[[storeLocation]] = !DILocation(line: 0`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78147/new/

https://reviews.llvm.org/D78147





More information about the llvm-commits mailing list