[PATCH] D78147: [LICM] Try to merge debug locations when sinking

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 14 15:45:51 PDT 2020


davide updated this revision to Diff 257525.
davide added a comment.

Most of the comment addressed. I didn't change the API because I'm not necessarily convinced that looping over uses is better than collecting debug values in a loop. 
I'm not entirely sure how general this API is going to be, but given we only have a use-case right now, we might re-evaluate later. I'm going to do some more work in this area so probably more scenarios will pop up.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78147/new/

https://reviews.llvm.org/D78147

Files:
  llvm/include/llvm/IR/DebugInfoMetadata.h
  llvm/lib/IR/DebugInfoMetadata.cpp
  llvm/lib/Transforms/Scalar/LICM.cpp
  llvm/test/Transforms/LICM/sink-debuginfo-preserve.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78147.257525.patch
Type: text/x-patch
Size: 9800 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200414/9af61ad2/attachment.bin>


More information about the llvm-commits mailing list