[PATCH] D77969: [LiveIntervals] Replace handleMoveIntoBundle

[Marcello Maggioni via Phabricator via llvm-commits]

kariddi added a comment.

I wonder if it would make sense to test that the SlotIndex is the same as the one of the bundle header after calling the method.



================
Comment at: llvm/include/llvm/CodeGen/LiveIntervals.h:318
     ///
-    /// Requires MI and BundleStart to have SlotIndexes, and assumes
-    /// existing liveness is accurate. BundleStart should be the first
-    /// instruction in the Bundle.
-    void handleMoveIntoBundle(MachineInstr &MI, MachineInstr &BundleStart,
-                              bool UpdateFlags = false);
+    /// Assumes existing livenewss is accurate.
+    /// BundleStart should be the first instruction in the Bundle.
----------------
s/livenewss/liveness/


================
Comment at: llvm/lib/CodeGen/LiveIntervals.cpp:1485
+  const SlotIndex NewIndex = Indexes->insertMachineInstrInMaps(BundleStart);
+  auto BundleEnd = getBundleEnd(BundleStart.getIterator());
+
----------------
Should we check that we are called on a bundled instruction?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77969/new/

https://reviews.llvm.org/D77969