[PATCH] D77969: [LiveIntervals] Replace handleMoveIntoBundle

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet accepted this revision.
qcolombet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/CodeGen/LiveIntervals.h:318
     ///
-    /// Requires MI and BundleStart to have SlotIndexes, and assumes
-    /// existing liveness is accurate. BundleStart should be the first
-    /// instruction in the Bundle.
-    void handleMoveIntoBundle(MachineInstr &MI, MachineInstr &BundleStart,
-                              bool UpdateFlags = false);
+    /// Assumes existing livenewss is accurate.
+    /// BundleStart should be the first instruction in the Bundle.
----------------
typo: livenewss


================
Comment at: llvm/include/llvm/CodeGen/LiveIntervals.h:319
+    /// Assumes existing livenewss is accurate.
+    /// BundleStart should be the first instruction in the Bundle.
+    /// BundleStart should not have a have SlotIndex as one will be assigned.
----------------
Maybe use the `\pre` marker to make it explicit that these are pre-conditions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77969/new/

https://reviews.llvm.org/D77969