[PATCH] D77417: [BFI][CGP] Add limited support for detecting missed BFI updates and fix one in CodeGenPrepare.

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D77417#1980889 <https://reviews.llvm.org/D77417#1980889>, @yamauchi wrote:

> In D77417#1980363 <https://reviews.llvm.org/D77417#1980363>, @lebedev.ri wrote:
>
> > In D77417#1960407 <https://reviews.llvm.org/D77417#1960407>, @lebedev.ri wrote:
> >
> > > There's already `-verify`, `-verify-dom-info`, etc.
> > >  I wonder if this should follow similar pattern?
> >
>
>
> The flag name was renamed from "check" to "verify".


Hmm, maybe i should be more verbose.
My question is, we already have some sudo-passes (`-verify`, `-verify-dom-info`)
that can be run after any pass, that verify that internal invariants still hold
at the time they are run are consistent. I may be wrong, but it seems like
this is adding a similar consistency check, but it is hardcoded to one particular
position of the pipeline - before CGP. So i'm wondering if i'm misreading that,
and if not whether it should be generalized so that BFI consistency can be checked
after any pass of choice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77417/new/

https://reviews.llvm.org/D77417