[PATCH] D77417: [BFI][CGP] Add limited support for detecting missed BFI updates and fix one in CodeGenPrepare.

Tue Apr 14 08:33:24 PDT 2020

yamauchi marked an inline comment as done.
yamauchi added a comment.

In D77417#1980363 <https://reviews.llvm.org/D77417#1980363>, @lebedev.ri wrote:

> In D77417#1960407 <https://reviews.llvm.org/D77417#1960407>, @lebedev.ri wrote:
>
> > There's already `-verify`, `-verify-dom-info`, etc.
> >  I wonder if this should follow similar pattern?
>

The flag name was renamed from "check" to "verify".

================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:233

+static cl::opt<bool>
+    VerifyBFIUpdates("cgp-verify-bfi-updates", cl::Hidden, cl::init(false),
----------------
davidxl wrote:
> is it useful to extend the verification to earlier passes in the future?
It would be (but it's not easy though.)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77417/new/

https://reviews.llvm.org/D77417