[PATCH] D78018: [scudo][standalone] Split logs on Android

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad marked an inline comment as done.
cryptoad added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/linux.cpp:187
+      }
+      // If no newline was found, something is likely wrong.
+      if (P == 0)
----------------
hctim wrote:
> Is this true? Should we just fallback to `async_safe_write_log` if we don't see a newline? example,
> 
> `common.cpp:25` has `outputRaw("Scudo ERROR: internal map or unmap failure");`, and while that'll still be output as it's less than 1024 characters, feels like the invariant that "if it has more than 1K characters it must have a newline" seems fragile.
More than 1024 chars with no newline shouldn't happen, particularly since we mostly want things that are human-understandable in the logs
But I'll just fallback to `async_safe_write_log`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78018/new/

https://reviews.llvm.org/D78018