[PATCH] D78018: [scudo][standalone] Split logs on Android
Mitch Phillips via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 13 13:00:10 PDT 2020
hctim added inline comments.
================
Comment at: compiler-rt/lib/scudo/standalone/linux.cpp:187
+ }
+ // If no newline was found, something is likely wrong.
+ if (P == 0)
----------------
Is this true? Should we just fallback to `async_safe_write_log` if we don't see a newline? example,
`common.cpp:25` has `outputRaw("Scudo ERROR: internal map or unmap failure");`, and while that'll still be output as it's less than 1024 characters, feels like the invariant that "if it has more than 1K characters it must have a newline" seems fragile.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78018/new/
https://reviews.llvm.org/D78018
More information about the llvm-commits
mailing list