[PATCH] D77990: [llvm-objdump][Wasm][NFC] Create WasmDump.h

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast marked 2 inline comments as done.
hubert.reinterpretcast added inline comments.


================
Comment at: llvm/tools/llvm-objdump/WasmDump.h:19
+namespace object {
+class WasmObjectFile;
+class ObjectFile;
----------------
MaskRay wrote:
> This is very nitpicking... WasmObjectFile inherits from ObjectFile so I would declare ObjectFile first.
I'm not sure I would do the same. The `WasmObjectFile` could be seen as being in block of "Wasm" related types (albeit with only one member currently).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77990/new/

https://reviews.llvm.org/D77990