[PATCH] D77990: [llvm-objdump][Wasm][NFC] Create WasmDump.h

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 13 09:39:44 PDT 2020


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/tools/llvm-objdump/WasmDump.h:19
+namespace object {
+class WasmObjectFile;
+class ObjectFile;
----------------
This is very nitpicking... WasmObjectFile inherits from ObjectFile so I would declare ObjectFile first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77990/new/

https://reviews.llvm.org/D77990





More information about the llvm-commits mailing list