[PATCH] D77888: Add -debugify-and-strip-all to add debug info before a pass and remove it after

[Daniel Sanders via Phabricator via llvm-commits]

dsanders marked an inline comment as done.
dsanders added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:827
+  SaveAndRestore<bool> SavedDebugifyIsSafe(DebugifyIsSafe);
+  if (Selector != SelectorType::GlobalISel || !isGlobalISelAbortEnabled())
+    DebugifyIsSafe = false;
----------------
vsk wrote:
> I'm confused by this: the comment says that "GlobalISel with the fallback path disabled and -run-pass seem to be unaffected". But here, IIUC if the fallback path is disabled (!isGlobalISelAbortEnabled), debugify is not safe. Is this a contradiction, or have I misunderstood what isGlobalISelAbortEnabled means?
> IIUC if the fallback path is disabled (!isGlobalISelAbortEnabled)

It's a bit unfortunate that we usually talk about the fallback path being enabled/disabled but the code says whether aborting is enabled. `!isGlobalISelAbortEnabled` means that aborting is disabled so we can continue into the fallback path



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77888/new/

https://reviews.llvm.org/D77888