[PATCH] D77888: Add -debugify-and-strip-all to add debug info before a pass and remove it after

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

This is really nice!



================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:818
+  // FIXME: Injecting into the DAGISel pipeline seems to cause issues with
+  //        analyses needing to be re-run this can result in being unable to
+  //        schedule passes (particularly with 'Function Alias Analysis
----------------
Period after 're-run'?


================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:827
+  SaveAndRestore<bool> SavedDebugifyIsSafe(DebugifyIsSafe);
+  if (Selector != SelectorType::GlobalISel || !isGlobalISelAbortEnabled())
+    DebugifyIsSafe = false;
----------------
I'm confused by this: the comment says that "GlobalISel with the fallback path disabled and -run-pass seem to be unaffected". But here, IIUC if the fallback path is disabled (!isGlobalISelAbortEnabled), debugify is not safe. Is this a contradiction, or have I misunderstood what isGlobalISelAbortEnabled means?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77888/new/

https://reviews.llvm.org/D77888