[PATCH] D77862: [CallSite removal][X86] Remove uses of CallSite from X86WinEHState.cpp

Fri Apr 10 10:53:50 PDT 2020

craig.topper marked an inline comment as done.
craig.topper added inline comments.

================
Comment at: llvm/lib/Target/X86/X86WinEHState.cpp:492
   } else {
-    auto *II = cast<InvokeInst>(Inst);
-    NewCS = Builder.CreateInvoke(
+    auto *II = cast<InvokeInst>(&Call);
+    NewCall = Builder.CreateInvoke(
----------------
rnk wrote:
> There is a crash with callbar here waiting to happen. Seems easy enough to trigger: use asm goto + EH on i686-windows-msvc.
> 
> I have a TODO to audit CodeGen for `cast<InvokeInst>`, since I saw another one of these, so I guess let's do nothing for now.
Aren't we only handling calls/invokes that have SetJmp3 as their callee? We shouldn't have a CallBr with that as a callee right?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77862/new/

https://reviews.llvm.org/D77862