[PATCH] D77862: [CallSite removal][X86] Remove uses of CallSite from X86WinEHState.cpp

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm, thanks for pushing the migration.



================
Comment at: llvm/lib/Target/X86/X86WinEHState.cpp:492
   } else {
-    auto *II = cast<InvokeInst>(Inst);
-    NewCS = Builder.CreateInvoke(
+    auto *II = cast<InvokeInst>(&Call);
+    NewCall = Builder.CreateInvoke(
----------------
There is a crash with callbar here waiting to happen. Seems easy enough to trigger: use asm goto + EH on i686-windows-msvc.

I have a TODO to audit CodeGen for `cast<InvokeInst>`, since I saw another one of these, so I guess let's do nothing for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77862/new/

https://reviews.llvm.org/D77862