[PATCH] D65649: [RISCV] Add MC encodings and tests of the Bit Manipulation extension

[Alex Bradbury via Phabricator via llvm-commits]

asb accepted this revision.
asb added a comment.

I think we should land this and continue further development in-tree. There might be a few minor refactorings I want to propose after the fact, but these shouldn't block this going forwards.

Thank you for all your work in putting this together and the care you've taken to do so in a way that matches the rest of the backend.



================
Comment at: llvm/test/MC/RISCV/rvZbproposedc-invalid.s:1
+# RUN: not llvm-mc -triple riscv32 -mattr=+experimental-b,c < %s 2>&1 | FileCheck %s
+
----------------
Nit: should be "-mattr=+experimental-zbproposedc,+c" given that +experimental-b won't turn on the proposed C additions by itself.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65649/new/

https://reviews.llvm.org/D65649