[PATCH] D77787: [MLIR] Introduce a trait that defines a new scope for auto allocation
Uday Bondhugula via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 9 07:01:41 PDT 2020
bondhugula added a comment.
In D77787#1971695 <https://reviews.llvm.org/D77787#1971695>, @ftynse wrote:
> Would it be possible to implement this without modifying `Operation`, i.e. as a simple trait rather than a trait based on a core operation property? Unlike "IsTerminator" and "IsolatedFromAbove", we don't have core mechanisms (which are the block verifier and the symbol resolver in the mentioned cases) that would mandate exposing this trait in Operation APIs.
The 'OperationProperty' enum class is missing its doc comment entirely - on how it's different from a trait that is not an OperationProperty. We should fix that first - the necessary information can't be determined locally without documentation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77787/new/
https://reviews.llvm.org/D77787
More information about the llvm-commits
mailing list