[PATCH] D77787: [MLIR] Introduce a trait that defines a new scope for auto allocation

[Alex Zinenko via Phabricator via llvm-commits]

ftynse added a comment.

Would it be possible to implement this without modifying `Operation`, i.e. as a simple trait rather than a trait based on a core operation property? Unlike "IsTerminator" and "IsolatedFromAbove", we don't have core mechanisms (which are the block verifier and the symbol resolver in the mentioned cases) that would mandate exposing this trait in Operation APIs.



================
Comment at: mlir/include/mlir/Dialect/GPU/GPUOps.td:89
+def GPU_GPUFuncOp : GPU_Op<"func", [FunctionLike, IsolatedFromAbove,
+                                    AutomaticAllocationScope, Symbol]> {
   let summary = "Function executable on a GPU";
----------------
Nit: can we keep this sorted alphabetically?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77787/new/

https://reviews.llvm.org/D77787