[PATCH] D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements.

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-exegesis.rst:210
+  could occur if the sampling is too frequent. A prime number should be used to
+  avoid consistently skipping certain blocks..
+  
----------------
typo: `..`


================
Comment at: llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp:107
+    std::string ErrMsg;
+    ~ThreadArg() {
+      if (CounterPtr != nullptr) {
----------------
std::unique_ptr + no dtor ?


================
Comment at: llvm/tools/llvm-exegesis/lib/BenchmarkRunner.h:50
 
+  // TODO(vyng) Make this "Deprecated" and switch caller to using RunArg
   Expected<InstructionBenchmark>
----------------
courbet wrote:
> The LLVM style is `FIXME`
`FIXME `and no name :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77422/new/

https://reviews.llvm.org/D77422